refactor: func NewWorkspace returns proper zero-values for empty function parameters #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanngiesser
force-pushed
the
new_workspace_keeps_zero_values
branch
from
733d073 to
93ad91c
Compare
kanngiesser
force-pushed
the
new_workspace_keeps_zero_values
branch
from
93ad91c to
12de896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Func NewWorkspace returns proper go zero-values for each function parameter that is empty.
This PR fixes unintended changes in the behavior of func NewWorkspace due to #1102 and causes the function to keep the principle of least confusion:
terraformTemplates,importParameterMappings,parametersToRemoveandparametersToAddare empty. This PR reverts this behaviour and keeps backwards-compabilityChecklist: