Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make syslog logging useable #411

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: make syslog logging useable #411

wants to merge 3 commits into from
+487 −17

Commits on Dec 4, 2024

  1. feat: make syslog logging useable 

    * do not log an empty new line when writing to syslog
* allow operator to configure truncation on syslog
    @maxmoehl
    maxmoehl committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    a7eb341 View commit details
    Browse the repository at this point in the history

  2. fix: allow syslog-only logging

    @maxmoehl
    maxmoehl committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    4eba73a View commit details
    Browse the repository at this point in the history

  3. feat: replace log/syslog with internal version 

    The go standard library implementation of log/syslog has been abandoned
and is no longer maintained. In our tests with syslog logging in
gorouter we noticed a significant performance penalty over file based
logging. However, with file based logging we frequently observe broken
logs because logrotate interferes with log reading / writing.

This commit inlines the relevant file from log/syslog and refactors the
implementation to be on-par with the file based logging.

Co-authored-by: Alexander Lais <[email protected]>
    @maxmoehl @peanball
    maxmoehl and peanball committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    e65fbfc View commit details
    Browse the repository at this point in the history