Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency credential test #435

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove dependency credential test #435

merged 1 commit into from
Jul 12, 2024

Conversation

sophiewigmore
Copy link
Member

  • the change in CDN results in these tests failing, because the new CDN config does not support credentials in this way.
  • we believe that consumers do not use this feature, as we have not had any reports of this causing failures for consumers.
  • if we get reports that consumers cannot download dependencies from the CDN with credentials, and we deem this to be a necessary feature, we can update the CDN config and re-add these tests.

cc @robdimsdale

@sophiewigmore sophiewigmore requested a review from a team as a code owner July 12, 2024 14:50
@sophiewigmore sophiewigmore merged commit feda5f0 into develop Jul 12, 2024
7 checks passed
@sophiewigmore sophiewigmore deleted the remove-dependency-credential-test branch July 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sophiewigmore