Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): migrate ContextMenu component to Typescript #596

Merged
merged 9 commits into from
Nov 11, 2024
Merged

chore(ui): migrate ContextMenu component to Typescript #596

merged 9 commits into from
Nov 11, 2024

Conversation

guoda-puidokaite
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite commented Nov 7, 2024 •
edited
Loading

Summary

  • Migrated the ContextMenu component to TypeScript, enhancing code quality, maintainability, and scalability.
  • Utilised static typing to minimize runtime errors and improve the development experience.
  • Deleted ContextMenu.component.js.
  • Note: Component to be deprecated so no code or documentation improvements made.

Changes Made

TypeScript Migration:

  • Converted ContextMenu component files to TypeScript.
  • Added comprehensive type annotations.

Testing:

  • Verified component behaviour using Storybook.
  • Updated tests to use vitest.

Release:

  • Generated a changeset file.

Related Issues

Testing Instructions

  1. Run Storybook
  2. Run Switch tests

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@guoda-puidokaite guoda-puidokaite self-assigned this Nov 7, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a4089c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-11 16:08 UTC

barsukov
barsukov requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments from my side

packages/ui-components/src/components/ContextMenu/ContextMenu.component.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/ContextMenu/ContextMenu.component.tsx Outdated Show resolved Hide resolved
@guoda-puidokaite guoda-puidokaite linked an issue Nov 8, 2024 that may be closed by this pull request
[TASK](ui): Migrate ContextMenu component to TypeScript #223
Closed
6 tasks
@guoda-puidokaite guoda-puidokaite changed the title Guoda convert contextmenu to ts chore(ui): migrate ContextMenu component to Typescript Nov 8, 2024
@guoda-puidokaite guoda-puidokaite mentioned this pull request Nov 7, 2024
Open
26 tasks
@guoda-puidokaite guoda-puidokaite marked this pull request as ready for review November 8, 2024 15:27
andypf
andypf approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andypf andypf added the ui-components All tasks related to juno-ui-components library label Nov 11, 2024
@guoda-puidokaite guoda-puidokaite added package All tasks related to package under packages/ enhancement New feature or request refactor labels Nov 11, 2024
barsukov
barsukov approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@guoda-puidokaite guoda-puidokaite merged commit b1a5eb1 into main Nov 11, 2024
15 checks passed
@guoda-puidokaite guoda-puidokaite deleted the guoda-convert-contextmenu-to-ts branch November 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypf andypf andypf approved these changes

@barsukov barsukov barsukov approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees

@guoda-puidokaite guoda-puidokaite

Labels
enhancement New feature or request package All tasks related to package under packages/ refactor ui-components All tasks related to juno-ui-components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK](ui): Migrate ContextMenu component to TypeScript
3 participants
@guoda-puidokaite @barsukov @andypf