Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): update dependencies to minor versions #648

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

taymoor89
Copy link
Contributor

@taymoor89 taymoor89 commented Nov 29, 2024

Summary

This PR updates dependencies to latest available minor versions. The only dependency that could not be upgraded to minor version is @floating-ui/react and will require a separate ticket.

Changes Made

  • Updated all dependencies to latest minor version except @floating-ui/react dependency.

  • Pinned all dependencies to the exact version by remove the caret ^

    • Why?
      Using ^ means allowing packages to be upgraded automatically up until the latest minor version but because of the nature of the open source packages it is not always guaranteed that, even, a patch update is non-breaking so the safest approach is to always use the exact version and have more confidence. Moreover, as from now on renovate will automatically open PRs for each new update so we'll be sure that each and every update to the dependencies is safe.
  • Due to these updates type checker is more strict now and there is one commit to fix a type issue.

  • Allowed renovate to start scanning for minor versions.

Screenshots (if applicable)

Testing Instructions

Manually test UI Components and make sure nothing is broken.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@taymoor89 taymoor89 requested review from franzheidl and a team as code owners November 29, 2024 17:19
Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: 13daeab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@taymoor89 taymoor89 added ui-components All tasks related to juno-ui-components library dependencies labels Nov 29, 2024
@taymoor89 taymoor89 mentioned this pull request Nov 29, 2024
1 task
Copy link
Contributor

github-actions bot commented Nov 29, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://cloudoperators.github.io/juno/pr-preview/pr-648/
on branch gh-pages at 2024-11-29 17:25 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant