Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): update dependencies to minor versions #648

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

taymoor89
Copy link
Contributor

@taymoor89 taymoor89 commented Nov 29, 2024

Summary

This PR updates dependencies to latest available minor versions. The only dependency that could not be upgraded to minor version is @floating-ui/react and will require a separate ticket.

Changes Made

  • Updated all dependencies to latest minor version except @floating-ui/react dependency.

  • Pinned all dependencies to the exact version by remove the caret ^

    • Why?
      Using ^ means allowing packages to be upgraded automatically up until the latest minor version but because of the nature of the open source packages it is not always guaranteed that, even, a patch update is non-breaking so the safest approach is to always use the exact version and have more confidence. Moreover, as from now on renovate will automatically open PRs for each new update so we'll be sure that each and every update to the dependencies is safe.
  • Due to these updates type checker is more strict now and there is one commit to fix a type issue.

  • Allowed renovate to start scanning for minor versions.

Screenshots (if applicable)

Testing Instructions

Manually test UI Components and make sure nothing is broken.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@taymoor89 taymoor89 requested review from franzheidl and a team as code owners November 29, 2024 17:19
Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 95916c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taymoor89 taymoor89 added ui-components All tasks related to juno-ui-components library dependencies labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-03 14:49 UTC

@taymoor89 taymoor89 force-pushed the taimoor-use-exact-version branch 2 times, most recently from 18cd98d to 8352639 Compare December 2, 2024 15:24
@taymoor89 taymoor89 merged commit 6877281 into main Dec 3, 2024
15 checks passed
@taymoor89 taymoor89 deleted the taimoor-use-exact-version branch December 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants