Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instancetype controller and instance provider add Create #23

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

helen-frank
Copy link
Contributor

@helen-frank helen-frank commented Sep 25, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add instancetype controller and instance provider add Create

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Copy link

gitautomator bot commented Sep 25, 2024

Thanks to your contribution, the maintainers will review it as soon as they can!

@jwcesign
Copy link
Contributor

Wait a little bit, after I make the related github workflow work, I will back to this PR.

@jwcesign
Copy link
Contributor

Please rebase this PR

@helen-frank helen-frank changed the title feat: add instancetype controller feat: add instancetype controller and instance provider add Create Sep 26, 2024
Copy link
Contributor

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jwcesign jwcesign merged commit b0ab632 into cloudpilot-ai:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants