feat: instancetype implement UpdateInstanceTypes and UpdateInstanceTypeOfferings #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to your contribution, the maintainers will review it as soon as they can! |
helen-frank
force-pushed
the
helen-frank/dev-general
branch
from
81dc8c9
to
76c57c4
Compare
|
Please take a look |
helen-frank
force-pushed
the
helen-frank/dev-general
branch
from
76c57c4
to
0e1115a
Compare
|
How to think about unit testing. AWS has implemented fake API(interface), but it seems difficult for Ali to do so. |
For now, our main focus is to finish building the minimum usable version. |
I agree with this suggestion. |
jwcesign
reviewed
Sep 29, 2024
daimaxiaxie
reviewed
Sep 29, 2024
daimaxiaxie
reviewed
Sep 29, 2024
daimaxiaxie
reviewed
Sep 29, 2024
helen-frank
force-pushed
the
helen-frank/dev-general
branch
from
0e1115a
to
d1bad85
Compare
helen-frank
force-pushed
the
helen-frank/dev-general
branch
2 times, most recently
from
b4466c3
to
a35b833
Compare
daimaxiaxie
reviewed
Sep 29, 2024
helen-frank
force-pushed
the
helen-frank/dev-general
branch
from
a35b833
to
9eb3c59
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
instancetype implement UpdateInstanceTypes and UpdateInstanceTypeOfferings
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?