-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement ecsclient #27
Conversation
Thanks to your contribution, the maintainers will review it as soon as they can! |
/cc @jwcesign @daimaxiaxie @IrisIris Please take a look |
2c56618
to
a062c03
Compare
After a phone call with @jwcesign, we decided to use |
a062c03
to
bb32a64
Compare
The current implementation provides access based on the currently provided authentication information, and subsequent implementations can be tracked: #29 /cc @jwcesign @daimaxiaxie @IrisIris Test Step:
func TestNewECSClient(t *testing.T) {
client, err := NewECSClient()
if err != nil {
t.Errorf("Failed to create ECS client: %v", err)
}
describeZonesRequest := &ecsclient.DescribeZonesRequest{
RegionId: client.RegionId,
}
runtime := &util.RuntimeOptions{}
if _, err := client.DescribeZonesWithOptions(describeZonesRequest, runtime); err != nil {
t.Error(err)
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @daimaxiaxie @IrisIris for final check
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implement ecsclient
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?