Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase robustness of two_servers_in_same_subnet #35

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

href
Copy link
Contributor

@href href commented Sep 20, 2023

Includes the following changes:

  • Launch more servers to find two matching servers.
  • Launch them less aggressively (mostly serialized on the API anyway).
  • Do not fail if a server cannot be launched, unless all servers fail.
  • Use launch parameters that are easy to adjust in the future.

This also includes the doc change from the reverted merge.

Includes the following changes:

* Launch more servers to find two matching servers.
* Launch them less aggressively (mostly serialized on the API anyway).
* Do not fail if a server cannot be launched, unless all servers fail.
* Use launch parameters that are easy to adjust in the future.

This also includes the doc change from the reverted merge.
@href href requested a review from gaudenz September 20, 2023 07:22
@href href self-assigned this Sep 20, 2023
Copy link
Contributor

@gaudenz gaudenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@href href merged commit 5146c7b into main Sep 20, 2023
@href href deleted the denis/two-servers-in-a-subnet branch February 9, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants