Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Floating IP mass reassignment tests #38

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

href
Copy link
Contributor

@href href commented Dec 22, 2023

This ensures that moving a large number of Floating IPs in one go propagates in a reasonable amount of time.

@href href requested a review from subsecond December 22, 2023 13:56
@href href force-pushed the denis/mass-reassign branch 5 times, most recently from c9e1b9e to 29fd3f6 Compare December 22, 2023 15:03
@href href force-pushed the denis/mass-reassign branch 3 times, most recently from 5f6ddae to cdcc4ed Compare January 4, 2024 13:46
This ensures that moving a large number of Floating IPs in one go
propagates in a reasonable amount of time.
@href href force-pushed the denis/mass-reassign branch from cdcc4ed to 5c78553 Compare January 4, 2024 14:17
Copy link

@subsecond subsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this version. Thanks a lot!

LGTM, ship it.

@href href merged commit 16d4e5f into main Jan 5, 2024
4 checks passed
@href href deleted the denis/mass-reassign branch February 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants