Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lambda expressions #219

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Nov 28, 2024

This PR implements lambda expressions.
Note: ast.LambdaArg is a one of ast.Arg. It is a same with ZetaSQL AST node.

parser.go Outdated Show resolved Hide resolved
ast/ast.go Outdated

Lparen token.Pos // optional

Args []*Ident
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be useful to mention len(Args) == 1 if Lparen.Invalid() here and the above template doc. What do you think?

Copy link
Contributor Author

@apstndb apstndb Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated e5e6033, d021e57

Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@makenowjust makenowjust merged commit 77fc9f8 into cloudspannerecosystem:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support lambda expressions
2 participants