catch more error types when rendering template to make it obvious the…

… error is in a template
cloudtruth · Sep 24, 2021 · 9036e07 · 9036e07
1 parent 74c3cc6
commit 9036e07
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/kubetruth/template.rb b/lib/kubetruth/template.rb
@@ -219,7 +219,7 @@ def render(*args, **kwargs)
 
         result
 
-      rescue Liquid::Error => e
+      rescue StandardError => e
         msg = "Template failed to render with error message:\n"
         msg << (INDENT * 2) << e.message << "\n"
         if e.is_a?(Liquid::UndefinedVariable)

diff --git a/spec/kubetruth/template_spec.rb b/spec/kubetruth/template_spec.rb
@@ -430,8 +430,10 @@ module Kubetruth
 
       it "fails fast" do
         expect { described_class.new("{{foo") }.to raise_error(Kubetruth::Template::Error)
+        expect { described_class.new("{{+}}").render }.to raise_error(Kubetruth::Template::Error)
         expect { described_class.new("{{foo}}").render }.to raise_error(Kubetruth::Template::Error)
         expect { described_class.new("{{foo | nofilter}}").render(foo: "bar") }.to raise_error(Kubetruth::Template::Error)
+        expect { described_class.new("{{foo | nindent: 2}}").render(foo: 5.5) }.to raise_error(Kubetruth::Template::Error)
       end
 
       it "does procs" do