Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drag and drop #23

Merged
merged 9 commits into from
Nov 15, 2024
Merged

feat: drag and drop #23

merged 9 commits into from
Nov 15, 2024

Conversation

r3tr0ananas
Copy link
Member

@r3tr0ananas r3tr0ananas commented Nov 4, 2024 •
edited
Loading

drag and drop yippie!!!

Note

This doesn't work on wayland :(
See rust-windowing/winit#1881

image

@THEGOLDENPRO
Copy link
Member

I think I'll just wait for wayland support

umaru-sleeping

@r3tr0ananas
Copy link
Member Author

r3tr0ananas commented Nov 5, 2024 •
edited
Loading

The issue opened 3 years ago, I don't think they'll fix it in the next few months. It works fine on every else except Wayland.

@THEGOLDENPRO
Copy link
Member

The pr is all good, now I just need to work on the dropping image attachment thingy I was talking about on Discord.

@r3tr0ananas
Copy link
Member Author

image

idk how to get the text closer to the rose without breaking centering stuff.

@THEGOLDENPRO
Copy link
Member

idk how to get the text closer to the rose without breaking centering stuff.

I can try and fix that don't worry about it

@THEGOLDENPRO
Copy link
Member

Screenshot_20241115_191146

@THEGOLDENPRO
Copy link
Member

I'm kinda confused, why is self.dropped_files even needed, can't we just use &i.raw.dropped_files? Is there a reason why we need to clone from &i.raw.dropped_files to self.dropped_files.

@r3tr0ananas
Copy link
Member Author

🔥

@r3tr0ananas
Copy link
Member Author

I'm kinda confused, why is self.dropped_files even needed, can't we just use &i.raw.dropped_files? Is there a reason why we need to clone from &i.raw.dropped_files to self.dropped_files.

not really, i just copied that from the example.

@THEGOLDENPRO
Copy link
Member

just saw the egui example, interesting...

@THEGOLDENPRO THEGOLDENPRO added the enhancement New feature or request label Nov 15, 2024
@THEGOLDENPRO THEGOLDENPRO merged commit 7e6f6ce into main Nov 15, 2024
@THEGOLDENPRO THEGOLDENPRO deleted the feat/drag-and-drop branch November 15, 2024 19:31
@THEGOLDENPRO THEGOLDENPRO mentioned this pull request Dec 5, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3tr0ananas @THEGOLDENPRO