Use corresponding response schema if a discriminator mapping is present for requests _and_ responses #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for requests _and_ responses
praneetloke
commented
May 17, 2024
| // Don't prefix the parent name since this resource | ||
| // will already be scoped under a module. | ||
| discriminatedResourceName := ToPascalCase(discriminatedValue) | ||
| resourceTypeToken, err := o.gatherResourceProperties(discriminatedResourceName, *typeSchema.Value, resourceResponseType, apiPath, module) | ||
| if resourceResponseType != nil && resourceResponseType.Discriminator != nil { | ||
| responseSchemaRef := resourceResponseType.Discriminator.Mapping[discriminatedValue] |
There was a problem hiding this comment.
The discriminated values will be the same between the request and the response since the API can't possibly return a new type that it can't handle a request for. In other words, consider the following discriminator mapping in the request schema:
discriminator:
propertyName: type
mapping:
"cat": "#/components/schemas/Cat"
The API can't return a dog type in the response, which wouldn't make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a discriminator mapping for a request type, if the response schema also contains a discriminator mapping, then use the corresponding mapped schema.