Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add a prefix to enum types if conflicting types have different values #157

Merged
merged 3 commits into from
May 25, 2024

Conversation

praneetloke
Copy link
Member

@praneetloke praneetloke commented May 24, 2024

We should do this because schema types in OpenAPI can have inline schema definitions. So a property in one type could refer to a shared enum type but in another type a similarly named property could have an inline enum schema with totally different values.

@praneetloke praneetloke merged commit 9c4d314 into main May 25, 2024
1 check passed
@praneetloke praneetloke deleted the praneetloke/enum-type-prefix branch May 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant