Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providers to pass a list of allowed plural resource names #161

Merged
merged 5 commits into from
May 27, 2024

Conversation

praneetloke
Copy link
Member

Resource name suffixes are trimmed of their "s" to join up the various operations. But some resource names are valid in their plural form. For example, while Databases is not a valid name for a resource (since it doesn't make sense that one would create multiple databases with one resource) and should be represented in the resources map as Database, a resource called Tags is likely legal because it could be a resource that allows the user to apply several tags to a resource and so Tags should be left alone. Another example is Kubernetes which should not be trimmed obviously but that's already part of the default list.

@praneetloke praneetloke merged commit 56b7ed3 into main May 27, 2024
1 check passed
@praneetloke praneetloke deleted the praneetloke/optional-plural-resources branch May 27, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant