Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.3 and update test suite #38

Closed
wants to merge 1 commit into from

Conversation

yadaiio
Copy link

@yadaiio yadaiio commented Apr 23, 2024

Builds on top of #30, #35, #36 and #37.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.

After this is merged, I also want to create another pull request that fix the typos, improve the documentation. 👍

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I have two suggestions that are currently missing from this PR:

  1. Can you also update the comment inside the phpunit.xml.legacy, similar to my changes in ReactPHP CSV
  2. We also use these PRs to improve the indentation inside the composer.json, similar to my changes in ReactPHP CSV

@SimonFrings
Copy link
Contributor

It also seems like the tests for HHVM are currently failing, didn't notice while reviewing. Can you look into this?

@yadaiio
Copy link
Author

yadaiio commented Apr 26, 2024

Looks good so far, I have two suggestions that are currently missing from this PR:

1. Can you also update the comment inside the `phpunit.xml.legacy`, similar to [my changes in ReactPHP CSV](https://github.com/clue/reactphp-csv/pull/33/files#diff-90e8ed4d404ab38c64ae8ee57d9df2b954891d9d57054048a77df0a385f3a612L3-R3)

2. We also use these PRs to improve the indentation inside the `composer.json`, similar to [my changes in ReactPHP CSV](https://github.com/clue/reactphp-csv/pull/33/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L23-R30)

Done! Thank you @SimonFrings 👍

@yadaiio
Copy link
Author

yadaiio commented Apr 26, 2024

It also seems like the tests for HHVM are currently failing, didn't notice while reviewing. Can you look into this?

It seems like we give an array in the React/Promise(any) function but HHVM expects an React\Promise\Iterable which doesn't exist. I decided to skip the tests for HHVM as the error message doesn't make much sense and HHVM is outdated anyway. Normally an array is the alias for iterable, see https://www.php.net/manual/en/language.types.iterable.php, so the thrown error message is invalid in my opinion.

Tests are running green now. 👍

errror

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the suggested changes, PR looks good to me 👍

composer.json Outdated Show resolved Hide resolved
@yadaiio yadaiio force-pushed the test_suite branch 5 times, most recently from 5b3960e to b42635d Compare April 30, 2024 07:21
composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes, looks good to me 👍

@SimonFrings SimonFrings requested a review from clue June 10, 2024 14:41
composer.json Show resolved Hide resolved
@clue clue added this to the v1.4.0 milestone Jun 16, 2024
@yadaiio
Copy link
Author

yadaiio commented Jun 28, 2024

As today is my last day working with you @clue, we agreed closing this pull request and revisit this later on.

If anyone is needing these changes earlier than expected, please consider sponsoring @clue via https://github.com/sponsors/clue. ❤️

@yadaiio yadaiio closed this Jun 28, 2024
@clue clue removed this from the v1.4.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants