-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on PHP 8.3 and update test suite #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I have two suggestions that are currently missing from this PR:
- Can you also update the comment inside the
phpunit.xml.legacy
, similar to my changes in ReactPHP CSV - We also use these PRs to improve the indentation inside the
composer.json
, similar to my changes in ReactPHP CSV
It also seems like the tests for HHVM are currently failing, didn't notice while reviewing. Can you look into this? |
b87442d
to
abef992
Compare
Done! Thank you @SimonFrings 👍 |
It seems like we give an Tests are running green now. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the suggested changes, PR looks good to me 👍
5b3960e
to
b42635d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes, looks good to me 👍
As today is my last day working with you @clue, we agreed closing this pull request and revisit this later on. If anyone is needing these changes earlier than expected, please consider sponsoring @clue via https://github.com/sponsors/clue. ❤️ |
Builds on top of #30, #35, #36 and #37.
References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.
After this is merged, I also want to create another pull request that fix the typos, improve the documentation. 👍