Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up (and debug) serial json output #786

Closed
wants to merge 10 commits into from
Closed

Conversation

kwalcock
Copy link
Member

@kwalcock kwalcock commented Mar 4, 2023

This is a draft because it depends on a processors update that needs to be published and there is still a small amount of test code remaining.

The most important enhancement is that the document.equivalenceHash is now cached and is not recalculated a bajillion times. Otherwise,

  • the mentions serialization package file has been replaced by a regular file
  • the mentions and related classes are not implicitly converted to MentionOps
  • triggers are converted to Bio and Coref instances
  • lots of duplicate code has been eliminated

This will be cleanup up and documented when processors is ready.

@kwalcock
Copy link
Member Author

kwalcock commented Mar 4, 2023

See #783, #784, #785.

@kwalcock kwalcock closed this Mar 9, 2023
@kwalcock kwalcock deleted the kwalcock/json2 branch March 9, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant