Pass regions as arguments #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the component, or specifically `getRegion()` will receive updates to data reactively (for instance if you do `{{#Layout template='layoutWithFooter' footer=someHelperThatReturnsATemplateName}}`).
So we can use `data()` as a secondary source of region names reliably, and all is roses :)
@cmather -- notice that it fails against master. Good job!
Conflicts: layout-test.js
Conflicts: layout-test.html layout-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris,
Please consider this PR more carefully. It allows usage like
As we discussed.
I would have just pushed this to devel but for one slightly controversial change -- see 812320c. Let me know if it's not clear why I had to do this, but I think it's a reasonable thing to do. All the IR + BL tests are passing and Verso seems to be working with this codebase, so I'm pretty happy with it.
Cheers