-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration scripts #2857
base: master
Are you sure you want to change the base?
Integration scripts #2857
Conversation
….24, clink-completions v0.4.7)
Updates to `3` vendored dependencies
Amazing stuff 👍🏻 Would you agree to moving some of the scripts to |
The scripts are where they are so they would be in the path when running Cmder from the distribution package because they work for our processes as well as for end users wanting to add Cmder to other terminals. Admittedly they are still in development and usefulness by end users is not fully proven yet. The |
Great, I propose the following changes. If you aprove, I'll implement them at a later time.
(For now, I propose that every script that starts with Additionally, I'd like to add two new scripts:
TBH, these scripts seem very useful to me! And I'm excited to getting them in the main branch. I hope you also agree with the additions that I'm going to work on. Thanks, Dax! |
P.S. So sorry for being late on the reviewing of your Awesome PRs. I'm also very excited for your speed PR, I'd like to review it sooner so we can merge it for the next release. Much appreciated! 👍🏻 |
Therenis already a script that does #2. |
Not sure the rationale for having two separate folders both added to the path when one folder added to the path does EXACTLY the same thing. |
Ah, thank you. I was thinking of keeping the |
I'm not that opinionated about it, and they don't NEED to be in the path. Just trying to make it easy for users and I HATE typing. |
@DRSDavidSoft New branch for us to work on integration scripts. It already has all the integration scripts in
vendor/bin
from thevagrant+packer
branch.Any changes to these should also be compatible with the
vagrant+packer
that will eventually be merged intomaster
.