Support for suggest2 API and modernization #107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for suggest2 API (disabled by default) * Honor limit parameter for number of choices returned * Add HTTP timeouts & retries with backoff * Add HTTP metrics * Add HTTP request header as required by LoC * refactor to minimize redundant code
Turn on caching by default
- Cherry-picked from yorkulibraries/lc-reconcile by @ruebot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly an information PR for some work in progress to see if there's any interest. I added support for the
suggest2API which does keyword searching of all variants in addition to left anchored searches, but it wasn't as big an improvement as I hoped. Things could also be extended to support the many new information types that the LoC now includes (e.g. BIBFRAME works).In addition to the new API, I added a bunch of additional stuff including:
limitparameter to control number of choices returnedI couldn't find any documentation on the
didyoumeanAPI and it doesn't seem to return many results, so I'm not sure how useful it is. More generally it's unclear to me what the best API or APIs to use is and the Library of Congress doesn't really provide much guidance. It would probably take more time than I have available currently to do enough experimentation to figure it out, but I'd be happy to accept feedback from an expert.