graceful fail for columns=0, #552

cmhughes · Jul 18, 2024 · 5596d5a · 5596d5a
1 parent fed474e
commit 5596d5a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/LatexIndent/Wrap.pm b/LatexIndent/Wrap.pm
@@ -659,6 +659,13 @@ sub text_wrap_comment_blocks {
     # call the text wrapping routine
     my $columns = ${ $mainSettings{modifyLineBreaks}{textWrapOptions} }{columns};
 
+    # fail gracefully if columns == 0
+    if ($columns==0){
+        $logger->warn("* textWrapOptions: columns is set to 0, can't text wrap with this");
+        ${ ${ $mainSettings{modifyLineBreaks}{textWrapOptions} }{comments} }{wrap} = 0;
+        return;
+    } 
+
     #
     # text wrap comment blocks
     #

diff --git a/test-cases/text-wrap/issue-552.tex b/test-cases/text-wrap/issue-552.tex
@@ -0,0 +1,2 @@
+% 1
+%  2
diff --git a/test-cases/text-wrap/issue-552.txt b/test-cases/text-wrap/issue-552.txt
@@ -0,0 +1,2 @@
+WARN:   textWrapOptions: columns is set to 0, can't text wrap with this
+       No objects found.
diff --git a/test-cases/text-wrap/issue-552.yaml b/test-cases/text-wrap/issue-552.yaml
@@ -0,0 +1,4 @@
+modifyLineBreaks:
+  textWrapOptions:
+    comments:
+      wrap: 1
diff --git a/test-cases/text-wrap/text-wrap-remove-PLB.sh b/test-cases/text-wrap/text-wrap-remove-PLB.sh
@@ -281,6 +281,11 @@ latexindent.pl -s -m -r -l issue-502.yaml,addruler2.yaml issue-502.tex -o=+-mod1
 latexindent.pl -s -m -r -l issue-502a.yaml,addruler2.yaml issue-502a.tex -o=+-mod1
 
 latexindent.pl -s -l issue-506.yaml -m issue-506.tex -o=+-mod1
+
+latexindent.pl -l issue-552.yaml -m issue-552.tex -s
+cp indent.log issue-552.txt
+perl -p0i -e 's/.*?(WARN)/$1/s' issue-552.txt
+perl -p0i -e 's/INFO:.*//s' issue-552.txt
 set +x
 [[ $gitStatus == 1 ]] && git status
 [[ $noisyMode == 1 ]] && makenoise