Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Conversation

lpetre-ulb
Copy link
Contributor

(Supersedes #137)

Description

Fixes all compilation issues in the updated build system up to the point where all RPM packages can be built seamlessly on gem904daq04. Further runtime tests are going to be performed in order to check the functionalities.

The changes are the following:

  • Update the config submodule in order to get the new PETA_PATH environment variable;
  • Cherry-pick the commits from Add log4cplus version awareness, fix #116 #117;
  • Compile against C++14 for the return type deduction support;
  • Fix a warning message in order to prevent memory corruption.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Compile the templated RPC framework with the updated build system.

How Has This Been Tested?

All RPM packages can be built out-of-the box on gem904daq04.

lpetre-ulb and others added 5 commits February 29, 2020 01:05
Implements the new PETA_PATH environment variable
log4cplus defines version macros, use them to fix the build failure mentioned in issue cms-gem-daq-project#116.
Enables auto return type deduction
@mexanick mexanick merged commit d465fe5 into cms-gem-daq-project:feature/templated-rpc-methods Feb 29, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 29, 2020
@lpetre-ulb lpetre-ulb deleted the bugfix/templated-rpc-methods-compilation branch February 29, 2020 13:19
@jsturdy
Copy link
Contributor

jsturdy commented Mar 2, 2020

Can we agree that we don't merge PRs on the weekend, unless they are specific hotfixes needed to be addressed for operational reasons?

@lpetre-ulb
Copy link
Contributor Author

lpetre-ulb commented Mar 2, 2020

Well, if the merging criteria are met, I don't see any good argument against merging PR on the weekend. If people want to work on the weekend, that's their problem. ;) If the merging criteria are too relaxed, they can be tighten (ideally with a CI which checks that all tests still pass).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants