This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
[feature] templated rpc methods #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd go for the first proposal, although I have not a strong opinion against the second one. |
Since most of the development was made in another repository all the history has been squashed in this commit.
Allow ADL usage in the documentation wording.
All exceptions thrown by RPC methods are caught, and an error message is sent via the "error" key. In order to help debugging, the type of the exception is also sent back to the client. Build system support is left for later.
The error key is set on the message when an exception is thrown by the RPC method. Throw an exception on the calling side when it is present.
The Wisconsin RPC messaging layer can throw a family of exceptions that need to be enumerated in catch() statements. Replace them with a common type deriving from std::runtime_error.
* `config` submodule updated to pick up `XHAL_ROOT` and default `INSTALL_PATH` * `xhalarm` and `xhalcore` `Makefile`s are simplified for reliable, reproducible builds * `xhalarm` as dependency of `xhalcore` is moved to dependency of `xhalcore.RPM`
This library is used by the RPC modules for the address table database. Since it is more of a support library, move it to this repository. Also use the original file name lmdb++.h instead of lmdb_cpp_wrapper.h.
The new class will be used to avoid passing the LMDB handle as an argument to every function. The implementation isn't very smart so far, but this can be improved without breaking the existing API. The new code is located in xhalarm because it is not usable on the client side.
* fix bug in arm makefile for packaging
* add lmdb to CI install step * add gem-peta-stage-ctp7 to install steps
* [ci] run publish jobs only on cms-gem-daq-project * [ci] create release job
…ries in expected location
* make spec template more generic * proper library flags
* Ensure proper dependencies for python setup files
* variable location for wiscrpcsvc
* Update python packages for CI * Try to run job without special runner * Test the publish stage
Implements the new PETA_PATH environment variable
Enables auto return type deduction
jsturdy
force-pushed
the
feature/templated-rpc-methods
branch
from
d465fe5 to
bea638d
Compare
jsturdy
changed the title
|
Forced option 1 |
mexanick
approved these changes
Mar 6, 2020
lpetre-ulb
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge in preliminary templated RPC changes
WIP because commits added to the
developbranch were incorporated independently into the templated branch and a decision on how to proceed should be made (order of preference):feature/templated-rpc-methodsontodevelopskipping duplicated commits (straightforward fix for two conflicts)Merge without action (conflict resolution addition/deletion of previously moved file)Types of changes
Motivation and Context
It's the way of the future
How Has This Been Tested?
In testing