Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py312][3/3] fixing SyntaxWarning warnings #2352

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[py312][3/3] fixing SyntaxWarning warnings #2352

merged 2 commits into from
Oct 2, 2024

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

A new Pull Request was created by @smuzaffar for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

Pull request #2352 was updated.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_5_3_X

@smuzaffar smuzaffar changed the title [py312][2/3] fixing SyntaxWarning warnings [py312][3/3] fixing SyntaxWarning warnings Oct 2, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd9aa1/41872/summary.html
COMMIT: 95def2e
CMSSW: CMSSW_5_3_X_2024-09-29-0000/slc6_amd64_gcc472
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2352/41872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7 KiB( 7 files compared)
  • Checked 37 log files, 21 edm output root files, 8 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 81829b5 into master Oct 2, 2024
17 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the py312-3 branch November 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants