Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT626] Root update v6 26 00 patches #8010

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_5_X/rootnext.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b24e5/26596/summary.html
COMMIT: c309412
CMSSW: CMSSW_12_5_ROOT626_X_2022-08-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8010/26596/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week0/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_ROOT626_X_2022-08-01-2300/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in 
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libPhysicsToolsPatUtils.so'
Suggestion: You can run 'scram build updateclassversion' to generate src/PhysicsTools/PatUtils/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc10/edm_checks/libPhysicsToolsPatUtils.so] Error 1
>> Checking EDM Class Version for src/PhysicsTools/Utilities/src/classes_def.xml in libPhysicsToolsUtilities.so
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/nweek-02744/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_ROOT626_X_2022-07-31-0000/lib/el8_amd64_gcc10/SimDataFormatsEncodedEventId_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.26/05 of ROOT.
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/nweek-02744/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_ROOT626_X_2022-07-31-0000/lib/el8_amd64_gcc10/CondFormatsGBRForest_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.26/05 of ROOT.
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 


@smuzaffar
Copy link
Contributor

@aandvalenzuela , this error is due to update to root version (https://github.com/root-project/root/blob/v6-26-00-patches/build/version_number : 6.26/07 ). please update root version to 6.26.07 in root.spec file and request a full cmssw PR test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

Pull request #8010 was updated.

@iarspider
Copy link
Contributor

test parameters:

  • full_cmssw = true

@iarspider
Copy link
Contributor

please test

@iarspider
Copy link
Contributor

@aandvalenzuela , this error is due to update to root version (https://github.com/root-project/root/blob/v6-26-00-patches/build/version_number : 6.26/07 ). please update root version to 6.26.07 in root.spec file and request a full cmssw PR test

Thanks, Shahzad!

@aandvalenzuela
Copy link
Contributor Author

Wow, that was a fast reaction! Thank you team :)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b24e5/26603/summary.html
COMMIT: 25a090a
CMSSW: CMSSW_12_5_ROOT626_X_2022-08-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8010/26603/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b24e5/26603/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b24e5/26603/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
1042.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16379 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3669004
  • DQMHistoTests: Total failures: 37843
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3631132
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26401.44599999999 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 202.334 KiB L1T/L1TStage2EMTF
  • DQMHistoSizes: changed ( 11634.0,... ): 3638.739 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): 86.660 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 11834.0 ): 2.372 KiB SiStrip/MechanicalView
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 5 / 50 workflows

@aandvalenzuela aandvalenzuela merged commit e2f1f52 into cms-sw:IB/CMSSW_12_5_X/rootnext Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants