-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AARCH64] jemalloc: explicitly set pagesize #9243
Conversation
A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/master. @aandvalenzuela, @iarspider, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
@fwyzard FYI |
please test for el8_aarch64_gcc12 |
-1 Failed Tests: Build BuildI found compilation error when building: src/FWCore/Concurrency/interface/chain_first.h:138:23: required from 'constexpr void edm::waiting_task::detail::RunLastAdaptor::pipe(edm::waiting_task::detail::WaitingTaskChain&&) [with T = {edm::beginStreamTransitionAsync >(WaitingTaskHolder, Schedule&, unsigned int, OccurrenceTraits::TransitionInfoType&, const ServiceToken&, std::vector&)::, edm::waiting_task::detail::AutoExceptionHandler >(WaitingTaskHolder, Schedule&, unsigned int, OccurrenceTraits::TransitionInfoType&, const ServiceToken&, std::vector&):: >}]' src/FWCore/Concurrency/interface/chain_first.h:203:23: required from 'auto edm::waiting_task::detail::operator|(WaitingTaskChain, V&&) [with V = RunLastAdaptor; U = edm::beginStreamTransitionAsync >(WaitingTaskHolder, Schedule&, unsigned int, OccurrenceTraits::TransitionInfoType&, const ServiceToken&, std::vector&)::; T = {AutoExceptionHandler >(WaitingTaskHolder, Schedule&, unsigned int, OccurrenceTraits::TransitionInfoType&, const ServiceToken&, std::vector&):: >}]' src/FWCore/Framework/interface/streamTransitionAsync.h:93:16: required from 'void edm::beginStreamTransitionAsync(WaitingTaskHolder, Schedule&, unsigned int, typename Traits::TransitionInfoType&, const ServiceToken&, std::vector&) [with Traits = OccurrenceTraits; typename Traits::TransitionInfoType = RunTransitionInfo]' src/FWCore/Framework/interface/streamTransitionAsync.h:105:41: required from 'void edm::beginStreamsTransitionAsync(WaitingTaskHolder, Schedule&, unsigned int, typename Traits::TransitionInfoType&, const ServiceToken&, std::vector&) [with Traits = OccurrenceTraits; typename Traits::TransitionInfoType = RunTransitionInfo]' src/FWCore/TestProcessor/src/TestProcessor.cc:473:44: required from here src/FWCore/Framework/interface/StreamSchedule.h:369:10: error: variable 'id' set but not used [-Werror=unused-but-set-variable] 369 | auto id = principal.id(); | ^~ src/FWCore/Framework/interface/StreamSchedule.h: In instantiation of 'void edm::StreamSchedule::processOneStreamAsync(edm::WaitingTaskHolder, typename T::TransitionInfoType&, const edm::ServiceToken&, bool) [with T = edm::OccurrenceTraits; typename T::TransitionInfoType = edm::LumiTransitionInfo]': src/FWCore/Framework/interface/Schedule.h:340:58: required from 'void edm::Schedule::processOneStreamAsync(edm::WaitingTaskHolder, unsigned int, typename T::TransitionInfoType&, const edm::ServiceToken&, bool) [with T = edm::OccurrenceTraits; typename T::TransitionInfoType = edm::LumiTransitionInfo]' src/FWCore/Framework/interface/streamTransitionAsync.h:75:7: required from 'edm::beginStreamTransitionAsync >(WaitingTaskHolder, Schedule&, unsigned int, OccurrenceTraits::TransitionInfoType&, const ServiceToken&, std::vector&):: [with auto:40 = edm::WaitingTaskHolder]' |
please test with cms-sw/cmssw#45205 for el8_aarch64_gcc12 |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
On GRID nodes, pagesize is set to 4096, while on lxplus-arm and vocms-arm it is 65536. If jemalloc was built on GRID node, using it on lxplus or vocms will cause failures (e.g.):
From install.MD for jemalloc:
Notice that this change may cause performance issues, see e.g. discussion here: jemalloc/jemalloc#2639 (comment)