Merge pull request #38823 from mmusich/fixDQMOfflineGUIindexingProblem

`SiStripHitEfficiencyWorker`: sanitize histogram names to avoid DQM Offline GUI indexing problem with `ALCAPROMPT` datasets
cms-sw · Jul 22, 2022 · 388f6a9 · 388f6a9
2 parents 34ddd51 + f558ce9
commit 388f6a9
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 8 deletions.
diff --git a/CalibTracker/SiStripHitEfficiency/interface/SiStripHitEfficiencyHelpers.h b/CalibTracker/SiStripHitEfficiency/interface/SiStripHitEfficiencyHelpers.h
@@ -23,6 +23,16 @@ namespace {
     k_END_OF_LAYS_AND_RINGS = 35
   };
 
+  inline void replaceInString(std::string& str, const std::string& from, const std::string& to) {
+    if (from.empty())
+      return;
+    size_t start_pos = 0;
+    while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
+      str.replace(start_pos, from.length(), to);
+      start_pos += to.length();  // In case 'to' contains 'from', like replacing 'x' with 'yx'
+    }
+  }
+
   inline unsigned int checkLayer(unsigned int iidd, const TrackerTopology* tTopo) {
     switch (DetId(iidd).subdetId()) {
       case SiStripSubdetector::TIB:

diff --git a/CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyWorker.cc b/CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyWorker.cc
@@ -319,9 +319,15 @@ void SiStripHitEfficiencyWorker::bookHistograms(DQMStore::IBooker& booker,
       const auto partition = (isTIB ? "TIB" : "TOB");
       const auto yMax = (isTIB ? 100 : 120);
 
-      const auto tit = Form("%s%i: Map of missing hits", partition, (isTIB ? layer : layer - bounds::k_LayersAtTIBEnd));
+      const auto& tit =
+          Form("%s%i: Map of missing hits", partition, (isTIB ? layer : layer - bounds::k_LayersAtTIBEnd));
 
-      auto ihhotcold = booker.book2D(tit, tit, 100, -1, 361, 100, -yMax, yMax);
+      // histogram name must not contain ":" otherwise it fails upload to the GUI
+      // see https://github.com/cms-DQM/dqmgui_prod/blob/af0a388e8f57c60e51111585d298aeeea943367f/src/cpp/DQM/DQMStore.cc#L56
+      std::string name{tit};
+      ::replaceInString(name, ":", "");
+
+      auto ihhotcold = booker.book2D(name, tit, 100, -1, 361, 100, -yMax, yMax);
       ihhotcold->setAxisTitle("#phi [deg]", 1);
       ihhotcold->setBinLabel(1, "360", 1);
       ihhotcold->setBinLabel(50, "180", 1);
@@ -332,14 +338,24 @@ void SiStripHitEfficiencyWorker::bookHistograms(DQMStore::IBooker& booker,
     } else {
       const bool isTID = layer <= bounds::k_LayersAtTIDEnd;
       const auto partitions =
-          (isTID ? std::vector<std::string>{"TID-", "TID+"} : std::vector<std::string>{"TEC-", "TEC+"});
+          (isTID ? std::vector<std::string>{"TIDplus", "TIDminus"} : std::vector<std::string>{"TECplus", "TECminus"});
       const auto axMax = (isTID ? 100 : 120);
       for (const auto& part : partitions) {
-        const auto tit = Form("%s%i: Map of missing hits",
-                              part.c_str(),
-                              (isTID ? layer - bounds::k_LayersAtTOBEnd : layer - bounds::k_LayersAtTIDEnd));
-
-        auto ihhotcold = booker.book2D(tit, tit, 100, -axMax, axMax, 100, -axMax, axMax);
+        // create the title by replacing the minus/plus symbols
+        std::string forTitle{part};
+        ::replaceInString(forTitle, "minus", "-");
+        ::replaceInString(forTitle, "plus", "+");
+
+        // histogram name must not contain ":" otherwise it fails upload to the GUI
+        // see https://github.com/cms-DQM/dqmgui_prod/blob/af0a388e8f57c60e51111585d298aeeea943367f/src/cpp/DQM/DQMStore.cc#L56
+        const auto& name = Form("%s %i Map of Missing Hits",
+                                part.c_str(),
+                                (isTID ? layer - bounds::k_LayersAtTOBEnd : layer - bounds::k_LayersAtTIDEnd));
+        const auto& tit = Form("%s%i: Map of Missing Hits",
+                               forTitle.c_str(),
+                               (isTID ? layer - bounds::k_LayersAtTOBEnd : layer - bounds::k_LayersAtTIDEnd));
+
+        auto ihhotcold = booker.book2D(name, tit, 100, -axMax, axMax, 100, -axMax, axMax);
         ihhotcold->setAxisTitle("Global Y", 1);
         ihhotcold->setBinLabel(1, "+Y", 1);
         ihhotcold->setBinLabel(50, "0", 1);