-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmsCodeRules fixes #37990
cmsCodeRules fixes #37990
Conversation
If a line doesn't end with newline, the script may try to read past last character in line and fail
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37990/30061
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test runtestRecoTauTagRecoTau had ERRORS RelVals
Expand to see more relval errors ...RelVals-INPUT
|
please test |
Are required deepTau model files already part of cms-data? Corresponding PR is already merged (cms-data/RecoTauTag-TrainingFiles#8), but could it be that it is not propagated to IB, yet? |
yes @mbluj , cms-sw/cmsdist#7876 (which integrate cms-data/RecoTauTag-TrainingFiles#8 changes in to cmssw) has been merged for last night IB (12.5.X 23h00) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2489f7/24810/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2489f7/28169/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
PR description:
PR validation:
Local tests