Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPS] Direct simulation as sequence #38280

Merged
merged 18 commits into from
Aug 4, 2022

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Jun 7, 2022

PR description:

This PR aims at transforming the collection of validation tools into a standard sequence for the direct simulation of strips/diamond/pixel detectors. Additionally to the moving of the CTPPSDirectProtonSimulation plugin (renamed PPSDirectProtonSimulation to follow the newest convention) from Validation/CTPPS to a dedicated SimPPS/DirectSimProducer subpackage, the configuration scripts calling this latter are also reshuffled to define a more concise, and era-based steering of the PPS direct simulation.

Consequently, this latter can now be added sequentially to a standard configuration via a standard cmsDriver customisation flag, e.g.
cmsDriver.py [...] --customise SimPPS/Configuration/Utils.setupPPSDirectSim[Mini]AOD

Additionally, a new 2022 PPS era was introduced in preparation to future conditions, both in reconstruction and in direct simulation. To ease the development of later conditions, the ctpps era is now considering run 3 detectors occupancy as its default scheme, and modifiers are only introduced for 2016-17 (with no pixels and no diamond subdetectors respectively)

PR validation:

We performed a bin-by-bin comparison of every distribution/profile introduced earlier in direct simulation validation tool and did not spot any noticeable difference.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38280/30430

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • Geometry/VeryForwardGeometry (geometry)
  • RecoPPS/Configuration (reconstruction)
  • RecoPPS/Local (reconstruction)
  • SimPPS/Configuration (simulation)
  • SimPPS/DirectSimProducer (****)
  • Validation/CTPPS (dqm)

The following packages do not have a category, yet:

SimPPS/DirectSimProducer
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@perrotta, @civanch, @Dr15Jones, @clacaputo, @makortel, @cvuosalo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @slava77, @jpata, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @grzanka, @missirol, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @bsunanda, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Jun 8, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70a87b/25354/summary.html
COMMIT: 818459f
CMSSW: CMSSW_12_5_X_2022-06-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38280/25354/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 08-Jun-2022 09:29:10 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 346512
   [1] Calling method for module CTPPSDiamondDQMSource/'ctppsDiamondDQMOfflineSource'
Exception Message:
No "VeryForwardRealGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 08-Jun-2022 09:33:50 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 326479
   [1] Calling method for module CTPPSDiamondDQMSource/'ctppsDiamondDQMOfflineSource'
Exception Message:
No "VeryForwardRealGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 08-Jun-2022 09:37:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module CTPPSDiamondDQMSource/'ctppsDiamondDQMOfflineSource'
Exception Message:
No "VeryForwardRealGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
  • 140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log
  • 140.57140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18/step2_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18.log
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 08-Jun-2022 09:34:04 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 5 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CTPPSLocalTrackLiteProducer/'ctppsLocalTrackLiteProducer'
   [4] Prefetching for module TotemRPLocalTrackFitter/'totemRPLocalTrackFitter'
   [5] Calling method for module TotemRPUVPatternFinder/'totemRPUVPatternFinder'
Exception Message:
No "VeryForwardRealGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 08-Jun-2022 09:33:32 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 272762 lumi: 51 event: 41643921 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CTPPSLocalTrackLiteProducer/'ctppsLocalTrackLiteProducer'
   [4] Prefetching for module TotemRPLocalTrackFitter/'totemRPLocalTrackFitter'
   [5] Calling method for module TotemRPUVPatternFinder/'totemRPUVPatternFinder'
Exception Message:
No "VeryForwardRealGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

@clacaputo
Copy link
Contributor

-reconstruction

@clacaputo
Copy link
Contributor

+reconstruction

@bsunanda
Copy link
Contributor

+geometry

@forthommel
Copy link
Contributor Author

@emanueleusai
Copy link
Member

+1

@forthommel
Copy link
Contributor Author

Thanks, @emanueleusai!
@davidlange6, @perrotta, @rappoccio, @qliphy, @fabiocos, @civanch, @mdhildreth, any help needed in your (second) review?

@civanch
Copy link
Contributor

civanch commented Aug 2, 2022

+1

@forthommel
Copy link
Contributor Author

Thanks, @civanch!
@davidlange6, @perrotta, @rappoccio, @qliphy, @fabiocos, any help needed in your (second) review?

@forthommel
Copy link
Contributor Author

I know you have a lot on your stack nowadays, but would it be possible to converge on this PR anytime soon? It has been almost two months since it was opened.

@qliphy
Copy link
Contributor

qliphy commented Aug 4, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit f10295e into cms-sw:master Aug 4, 2022
@forthommel
Copy link
Contributor Author

Many thanks, @qliphy !

@forthommel forthommel deleted the pps-direct_simu_stdseq-12_5_X branch August 4, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.