-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported chars from PPSAlignmentWorker #38928
Conversation
type ctpps,bugfix |
test parameters:
|
Weird that 1042 passed. You should also update PPSAlignmentHarvester and PPSAlignmentConfigurationESSource. |
Sorry I dont follow, why is that weird? |
Because you changed the paths of the plots which are used by the harvester. If there is no error, then I assume that the results are empty. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38928/31374
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The worker encodes some numbers in the paths, that's why there were points in the first place. If they are replaced by 'p', the harvester cannot properly decode them as doubles. |
So I learned @MatiXOfficial actually have made his own version of the solution, thus I'm closing this PR |
-alca |
PR description:
Quick fix to #38885
PPS experts will follow up when we are less constrained in time with possible optimization (like refactoring the loop)
PR validation:
Ran wf 1042
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but needs to backport to 12_4_X