Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[124X] Fixed PPS Global Alignment path #38931

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

MatiXOfficial
Copy link
Contributor

PR description:

See #38930

PR validation:

See #38930

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38930

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for CMSSW_12_4_X.

It involves the following packages:

  • CalibPPS/AlignmentGlobal (alca)
  • CalibPPS/ESProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @mmusich, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 1, 2022

backport of #38930

@tvami
Copy link
Contributor

tvami commented Aug 1, 2022

test parameters:

  • workflows = 1042

@tvami
Copy link
Contributor

tvami commented Aug 1, 2022

type bugfix,ctpps

@tvami
Copy link
Contributor

tvami commented Aug 1, 2022

urgent

  • needed for datataking

@tvami
Copy link
Contributor

tvami commented Aug 1, 2022

@cmsbuild , please test

@MatiXOfficial MatiXOfficial force-pushed the fix_pps_alignment_paths_124X branch from 342b068 to aa459ce Compare August 1, 2022 22:19
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

Pull request #38931 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Aug 1, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-130156/26584/summary.html
COMMIT: aa459ce
CMSSW: CMSSW_12_4_X_2022-08-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38931/26584/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-130156/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3676234
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676198
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.141 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1042.0 ): -0.141 KiB AlCaReco/PPSAlignment
  • Checked 212 log files, 45 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

+alca

  • differences in msgLogger and MTD
  • relval 1042 passes

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 3, 2022

+1

@cmsbuild cmsbuild merged commit 409fac5 into cms-sw:CMSSW_12_4_X Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants