Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of totemTriggerRawToDigi sequence remnants #38991

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Aug 8, 2022

PR description:

Following the merge of #38886 and the replacement of FED 577 from a Totem trigger to the new Totem T2 readout component, making the totemTriggerRawToDigi sequence obsolete, a few leftover modifications were found in L1T stage 2 emulator DQM sequence. This yielded a TestDQMOnlineClient unit test failure reported in #38987.
These leftovers are dropped in this PR. This fixes #38987.

PR validation:

scram b unittests raises no failure in TestDQMOnlineClient unit test.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38991/31455

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Aug 8, 2022

type bugfix

@qliphy
Copy link
Contributor

qliphy commented Aug 8, 2022

please test

@forthommel
Copy link
Contributor Author

It seems that I was too optimistic with my local tests, as I did not spot the failures observed in the current CI run in my logs search... Latest push also removes the totemT2 sequence not included by default into the standard reco path.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38991/31458

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

Pull request #38991 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@forthommel
Copy link
Contributor Author

Can someone please re-issue the tests?

@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d91a63/26715/summary.html
COMMIT: 1705626
CMSSW: CMSSW_12_5_X_2022-08-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38991/26715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691612
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3691582
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

@cms-sw/dqm-l2 Do you have any comment? This PR is to fix IB issue: #38987

@forthommel
Copy link
Contributor Author

@mmusich
Copy link
Contributor

mmusich commented Aug 9, 2022

ping @cms-sw/dqm-l2

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 10, 2022

+1

@cmsbuild cmsbuild merged commit 336c159 into cms-sw:master Aug 10, 2022
@forthommel forthommel deleted the dqmonlineclient-fix branch August 10, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestDQMOnlineClient unit failures
5 participants