-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of totemTriggerRawToDigi sequence remnants #38991
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38991/31455
|
A new Pull Request was created by @forthommel (Laurent Forthomme) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix |
please test |
e6e6b90
to
1705626
Compare
It seems that I was too optimistic with my local tests, as I did not spot the failures observed in the current CI run in my logs search... Latest push also removes the totemT2 sequence not included by default into the standard reco path. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38991/31458
|
Pull request #38991 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
Can someone please re-issue the tests? |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d91a63/26715/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 Do you have any comment? This PR is to fix IB issue: #38987 |
ping @cms-sw/dqm-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the merge of #38886 and the replacement of FED 577 from a Totem trigger to the new Totem T2 readout component, making the
totemTriggerRawToDigi
sequence obsolete, a few leftover modifications were found in L1T stage 2 emulator DQM sequence. This yielded aTestDQMOnlineClient
unit test failure reported in #38987.These leftovers are dropped in this PR. This fixes #38987.
PR validation:
scram b unittests
raises no failure inTestDQMOnlineClient
unit test.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: N/A