Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning the folder name of the per path histograms [12_5_X] #40134

Conversation

missirol
Copy link
Contributor

backport of #40121

PR description:

From the description of #40121 by @Sam-Harper:

TSG timing measurements are failing when moving from CMSSW_12_4_X with the error

An exception of category 'BadMonitorElementPathName' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
 Monitor element path name: 'merService/process TIMING paths/endpath @finalPath/path time_thread' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

This was traced to #38831.

The fixes in #38963 and #38966 did not go far enough, the uncleaned name of the path also appears in the folder of the perpath dqm plots (which are not always run, hence the previous reporter didnt notice this).

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40121

Fix to a functionality used by HLT developers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

type bugfix

@perrotta @rappoccio

This PR is the 12_5_X backport of the fix in #40121, mainly for the convenience of HLT developers using that release. This change does not affect any production workflow, and it does not require a new release (if there won't be a new 12_5_X release, at least users will have a PR they can merge locally, on top of 12_5_2_patch1).

Still, I hope it is no problem to merge it in 12_5_X.

PS. A backport to 12_4_X is not needed, because the PR (#38831) that triggered the problem fixed by this PR was only merged in 12_5_X.

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25f1f7/29195/summary.html
COMMIT: f367bf3
CMSSW: CMSSW_12_5_X_2022-11-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40134/29195/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3734847
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

  • Taking this as a "+1" from @cms-sw/hlt-l2

@cmsbuild cmsbuild merged commit cb6e6dc into cms-sw:CMSSW_12_5_X Nov 23, 2022
@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants