Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Update ROOT and Cling to LLVM18 #209

Closed

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    6d19058 View commit details
    Browse the repository at this point in the history
  2. [df] Allow reading std::array branches from TTree

    Add a specialization of RTreeColumnReader that reads values from a branch of
    type std::array. The specialization uses the non-adopting view from RVec to
    expose the contents of the array to nodes of the graph.
    vepadulano committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    657773f View commit details
    Browse the repository at this point in the history
  3. [ci] Disable the win x86 dbg platform

    for all builds since it is subject to timeouts when the build
    happens from scratch.
    dpiparo committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d110ff6 View commit details
    Browse the repository at this point in the history
  4. [doxygen] use jsroot v7 modules for embeding

    Use normal import function to control proper loading
    of JSROOT modules. No need to use older JSRoot.core.js
    linev committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    26f20db View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    ca9aa3e View commit details
    Browse the repository at this point in the history
  2. [ntuple] split RColumnElement defs into a separate private header

    This is required to make ntuple_endian.cxx work, as that test needs to
    force the endianness to be big endian. This is impossible to achieve if
    the definitions of RColumnElement are not accessible to it at compile
    time.
    silverweed committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0a53441 View commit details
    Browse the repository at this point in the history
  3. [ntuple] some cleanups in RColumnElement

    - removed Double32 case (it's redundant with double)
    - removed void case in non-specialized RColumnElementBase::Generate
    - added `using` for RColumnElementBase
    silverweed committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5b62c7e View commit details
    Browse the repository at this point in the history
  4. [minuit] use std::string instead of vector<char>

    gcc14 complains when vector<char> is used. Provides warning:
    ```
    In file included from /usr/include/c++/14/x86_64-suse-linux/bits/c++allocator.h:33,
                     from /usr/include/c++/14/bits/allocator.h:46,
                     from /usr/include/c++/14/vector:63,
                     from /home/linev/git/webgui/math/minuit2/inc/Minuit2/MnPlot.h:14,
                     from /home/linev/git/webgui/math/minuit2/src/MnPlot.cxx:10:
    In member function ‘void std::__new_allocator<_Tp>::deallocate(_Tp*, size_type) [with _Tp = char]’,
        inlined from ‘constexpr void std::allocator< <template-parameter-1-1> >::deallocate(_Tp*, std::size_t) [with _Tp = char]’ at /usr/include/c++/14/bits/allocator.h:208:35,
        inlined from ‘static constexpr void std::allocator_traits<std::allocator<_Up> >::deallocate(allocator_type&, pointer, size_type) [with _Tp = char]’ at /usr/include/c++/14/bits/alloc_traits.h:513:23,
        inlined from ‘constexpr std::vector<_Tp, _Alloc>::_M_realloc_append(_Args&& ...)::_Guard::~_Guard() [with _Args = {char}; _Tp = char; _Alloc = std::allocator<char>]’ at /usr/include/c++/14/bits/vector.tcc:616:18,
        inlined from ‘constexpr void std::vector<_Tp, _Alloc>::_M_realloc_append(_Args&& ...) [with _Args = {char}; _Tp = char; _Alloc = std::allocator<char>]’ at /usr/include/c++/14/bits/vector.tcc:688:7,
        inlined from ‘constexpr std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::emplace_back(_Args&& ...) [with _Args = {char}; _Tp = char; _Alloc = std::allocator<char>]’ at /usr/include/c++/14/bits/vector.tcc:123:21,
        inlined from ‘constexpr void std::vector<_Tp, _Alloc>::push_back(value_type&&) [with _Tp = char; _Alloc = std::allocator<char>]’ at /usr/include/c++/14/bits/stl_vector.h:1301:21,
        inlined from ‘void ROOT::Minuit2::MnPlot::operator()(double, double, const std::vector<std::pair<double, double> >&) const’ at git/webgui/math/minuit2/src/MnPlot.cxx:51:18:
    /usr/include/c++/14/bits/new_allocator.h:172:33: warning: ‘void operator delete(void*, std::size_t)’ called on pointer ‘<unknown>’ with nonzero offset [1, 576460752303423489] [-Wfree-nonheap-object]
      172 |         _GLIBCXX_OPERATOR_DELETE(_GLIBCXX_SIZED_DEALLOC(__p, __n));
          |                                 ^
    In member function ‘_Tp* std::__new_allocator<_Tp>::allocate(size_type, const void*) [with _Tp = char]’,
        inlined from ‘constexpr _Tp* std::allocator< <template-parameter-1-1> >::allocate(std::size_t) [with _Tp = char]’ at /usr/include/c++/14/bits/allocator.h:196:40,
        inlined from ‘static constexpr _Tp* std::allocator_traits<std::allocator<_Up> >::allocate(allocator_type&, size_type) [with _Tp = char]’ at /usr/include/c++/14/bits/alloc_traits.h:478:28,
        inlined from ‘constexpr std::_Vector_base<_Tp, _Alloc>::pointer std::_Vector_base<_Tp, _Alloc>::_M_allocate(std::size_t) [with _Tp = char; _Alloc = std::allocator<char>]’ at /usr/include/c++/14/bits/stl_vector.h:380:33,
        inlined from ‘constexpr void std::vector<_Tp, _Alloc>::reserve(size_type) [with _Tp = char; _Alloc = std::allocator<char>]’ at /usr/include/c++/14/bits/vector.tcc:79:33,
        inlined from ‘void ROOT::Minuit2::MnPlot::operator()(double, double, const std::vector<std::pair<double, double> >&) const’ at git/webgui/math/minuit2/src/MnPlot.cxx:50:16:
    /usr/include/c++/14/bits/new_allocator.h:151:55: note: returned from ‘void* operator new(std::size_t)’
      151 |         return static_cast<_Tp*>(_GLIBCXX_OPERATOR_NEW(__n * sizeof(_Tp)));
          |                                                       ^
    ```
    linev committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    90d057e View commit details
    Browse the repository at this point in the history
  5. [minuit] simplify loop over points

    Use std::vector::data() as pointer on vector begin
    linev committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ba1cf53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dc6ced7 View commit details
    Browse the repository at this point in the history
  7. [core] Do not provide source string length to strncpy

    Last argument in strncpy is length of destination buffer
    and should not depend from length of source string.
    Fixes warning from gcc14:
    ```
    git/webgui/core/meta/src/TClass.cxx:701:20: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Wstringop-truncation]
      701 |             strncpy(line + kvalue, *ppointer, std::min( i, kline - kvalue));
          |             ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    git/webgui/core/meta/src/TClass.cxx:691:20: note: length computed here
      691 |          i = strlen(*ppointer);
          |              ~~~~~~^~~~~~~~~~~
    ```
    linev committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    99d92be View commit details
    Browse the repository at this point in the history
  8. [gui] fix calloc usage in TGFileItem

    Size of single element is second argumernt in the `calloc` call.
    Fix warning from gcc14:
    ```
    git/webgui/gui/gui/src/TGFSContainer.cxx: In member function ‘void TGFileItem::SetDNDData(TDNDData*)’:
    git/webgui/gui/gui/src/TGFSContainer.cxx:468:28: warning: ‘void* calloc(size_t, size_t)’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
      468 |    fDNDData.fData = calloc(sizeof(unsigned char), data->fDataLength);
          |                            ^~~~~~~~~~~~~~~~~~~~~
    git/webgui/gui/gui/src/TGFSContainer.cxx:468:28: note: earlier argument should specify number of elements, later size of each element
    ```
    linev committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fb1ddc8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6214a86 View commit details
    Browse the repository at this point in the history
  10. [RF] Remove RooRealMPFE from public interface

    The RooRealMPFE class is an implementation detail of the old RooFit
    multiprocessing. It should not be part of the public interface, and also
    not have a `ClassDef` that allows you to do IO with it.
    guitargeek committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    50088e5 View commit details
    Browse the repository at this point in the history
  11. [RF] Rename and improve RooStatsUtils::MakeCleanWorkspace

      * The `RooStatsUtils::MakeCleanWorkspace` function was implemented by
        ATLAS framework developers, who remain its only users until now
    
      * They requested changing the function in root-project#7823 and there is no clear
        reason to deny this request
    
    Closes root-project#7823.
    guitargeek committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fe59efb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. [doxygen] use relative position for JSROOT drawings

    Avoid expansion of JSROOT drawing on full HTML page
    linev committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3f9d22a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b9947e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c2cd687 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9fa2309 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    74c0837 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f97315e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    543b738 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dc5513b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    005ed6e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    09c29c0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e7cfd6c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e868480 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7d6d858 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bebc65d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1bf2e55 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    23ce70a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    719ca8f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6dcae9e View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    84e665e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    171484d View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    b9a41e5 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    f7aab70 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    4ae7c1d View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    6b71ee0 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    d78734a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    6a4f114 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    1f47779 View commit details
    Browse the repository at this point in the history
  28. [tree] Remove superfluous deletion in destructor

    The fProxies data member appears later than the fDirector data member in the class definition, so it will be destroyed first.
    vepadulano committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    43a8143 View commit details
    Browse the repository at this point in the history
  29. [tree] Introduce error handling for number of events

    This commit fixes root-project#9137
    
    Introduces logic in TTreeReader to detect the cases in which one or more friend
    trees have a different number of entries than the main tree. Two main situations
    arise:
    * In case the main tree is longer than the friend, throw an exception
    * In case the main tree is shorter, issue a warning
    
    Note that this logic only treats the case of friends without event matching
    (i.e. without using TTreeIndex)
    vepadulano committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1b1ee9d View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    26af523 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    846aebf View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. [rdf] remove lambda from InterfaceUtils.hxx

    Gives no any advantage
    linev committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    58a96e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    efb7e2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0eefd59 View commit details
    Browse the repository at this point in the history
  3. [ntuple] Add first evolution test for removed members

    This is handled transparently on the reader side by not creating the
    removed field(s) and column(s).
    hahnjo committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    62b694c View commit details
    Browse the repository at this point in the history
  4. [ntuple] Add evolution test for removed base class

    This is again handled transparently on the reader side by not creating
    fields and columns of the removed base class.
    hahnjo committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5fe2db0 View commit details
    Browse the repository at this point in the history
  5. [ntuple] Add evolution test for reordered members

    This case is transparent on the reader side because fields are looked
    up by name.
    hahnjo committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a0a9764 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6257ea5 View commit details
    Browse the repository at this point in the history
  7. [tree] Report info about missing branch from TBranchProxy

    When setting the branch proxy, report info about a missing branch to the user.
    This is done in the form of a printed error. The logic is only triggered if
    there are no other branch names in the list of available branches that begin
    with the current branch name being searched. This situation could arise for
    example with a skeleton analysis produced by TTree::MakeProxy and a TTree with a
    split object. In that case the generated code will try to create a TBranchProxy
    for the top-level branch, even though that branch is not available from the
    TTree, only the sub-branches are.
    
    See for more details the discussion at root-project#3746
    vepadulano committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f97c2bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    21c3f92 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    858d6cc View commit details
    Browse the repository at this point in the history
  10. [NFC][ntuple] update locator specification

      - Replace string locator (type 0x01) by large (64bit size) locator
      - Make content size in DAOS locator either 32bit or 64bit wide, as
        needed
    jblomer committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2e79b87 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    54f1eb6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    00d26d1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5cbb2bd View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d76f9a9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    823b4c7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2bd23fc View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3137d04 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    12ddb3b View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    07b289b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d4746dd View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    d3c928b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a23ca8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f47ab8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6727c0c View commit details
    Browse the repository at this point in the history
  5. [Math] Implement code suggestions by clang-tidy

    Using almost all of the checks specified in `roofit/.clang-tidy`.
    guitargeek committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f381672 View commit details
    Browse the repository at this point in the history
  6. [ntuple] new column type: Real32Trunc

    Adds a new column type: Real32Trunc, which is a IEEE-754 single
    precision float truncated to [10, 31] bits.
    silverweed committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    aede851 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1b7b3a8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ced9666 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cb996b7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ee91d86 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d7e722e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f7eb8d8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cb9afb7 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4f68805 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0e50896 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    cb2b7ac View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    24392c3 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    633cddb View commit details
    Browse the repository at this point in the history
  19. [RF] Don't share a single static fitter for all RooMinimizer instances

    This improves thread safety in RooFit, as inspired by a recent forum
    post where someone wanted to do multiple fits in parallel.
    
    It was checked that this has no visible impact on performance.
    guitargeek committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    178fd6a View commit details
    Browse the repository at this point in the history
  20. [RF] Fix copy-paste typo in RooMinimizer

    Fix a bug where the status code when running "simplex" was set to
    "SEEK". This can happen when copy-pasting code.
    guitargeek committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d3f6a54 View commit details
    Browse the repository at this point in the history
  21. [RF] Avoid code duplication in RooMinimizer

    Purely internal and technical change.
    guitargeek committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c43cd7f View commit details
    Browse the repository at this point in the history
  22. [ntuple] disable -Warray-bounds in ntuple_packing.cxx

    It produces false positives on memcpy "out of bounds"
    silverweed committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e5bc43f View commit details
    Browse the repository at this point in the history
  23. [hist] Implement code suggestions by clang-tidy

    Using almost all of the checks specified in `roofit/.clang-tidy`.
    guitargeek committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    16ecb6e View commit details
    Browse the repository at this point in the history
  24. [tree][NFC] Add docs to TTree::GetEntriesFast

    Showcasing the main strength of this function compared to TTree::GetEntries
    vepadulano committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    064217a View commit details
    Browse the repository at this point in the history
  25. [Minuit2] Use std::span instead of std::vector const& for parameters

    Use `std::span` instead of `std::vector const&` for function parameters
    in Minuit2.
    
    The motivation is that `std::span` is more general. If the function
    takes a `std::vector const&`, the inputs are forced to be allocated on
    the heap. So if one wants to call functions with constant size or even
    scalar input, that would cause a large overhead.
    
    This overhead can be avoided when generalizing with `std::span`.
    
    The standalone Minuit2 build files were also changed to consider the
    `std::span` backport to C++17 that is already in ROOT.
    guitargeek committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    63636f6 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    bda8514 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    b81f1ca View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. [CMake] Set the minimum required version to 3.20

    This is required to build LLVM18.
    This version of CMake was eleased in March 2021
    https://github.com/Kitware/CMake/releases/tag/v3.20.0
    dpiparo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3e03f78 View commit details
    Browse the repository at this point in the history
  2. Import ROOT-llvm18

    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b0907c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b06505 View commit details
    Browse the repository at this point in the history
  4. [cling] Rename enums to match upstream LLVM 18

    - Rename `CharacterLiteral` enum to `CharacterLiteralKind`
    - Rename `CGFT_{}` enums to `CodeGenFileType::{}`
    - Rename `ETK_{}` enums to `ElaboratedTypeKeyword::{}`
    - Rename `TTK_{}` enums to `TagTypeKind::{}`
    - Use `ArraySizeModifier` and `StringLiteralKind`
    - Use `LinkageSpecLanguageIDs`
    - Rename `llvm::CodeGenOpt::Level` to `llvm::CodeGenOptLevel`
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    955bc36 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf8248d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    768c114 View commit details
    Browse the repository at this point in the history
  7. [cling] Register callbacks with MAM instead of FAM

    We have to get the FAM via the MAM otherwise it won't invalidate function
    analyses in FAM
    
    See: https://reviews.llvm.org/D146160
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9a3cdbd View commit details
    Browse the repository at this point in the history
  8. [cling] Include missing headers

    - Include `EnterExpressionEvaluationContext.h`
    This was moved to its own header in:
    llvm/llvm-project@6d68805
    
    - Include `StringExtras.h`
    This is now needed due to:
    llvm/llvm-project@3ff3af3
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9231dba View commit details
    Browse the repository at this point in the history
  9. [cling] Update includes to match headers moved to TargetParsers

    Adapt to the changes introduces in:
    - llvm/llvm-project@f09cf34
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5d5f32a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a55f39b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    59dcfa7 View commit details
    Browse the repository at this point in the history
  12. [cling] Use isPureVirtual

    Corresponding to the changes in:
    - llvm/llvm-project#78463
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    58c7cf7 View commit details
    Browse the repository at this point in the history
  13. [cling] Update ReadPreprocessorOptions parameters

    Make changes corresponding to the LLVM commit:
    - llvm/llvm-project@6a11557
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a875d7e View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7f73f75 View commit details
    Browse the repository at this point in the history
  15. [cling] Rename OpenMPIsDevice to OpenMPIsTargetDevice

    Rename as per the changes in the LLVM commit:
    - llvm/llvm-project@63ca93c
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5a0afb1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3403b14 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d4c16b6 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    7cf2f6c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    c0551b7 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b83614c View commit details
    Browse the repository at this point in the history
  21. [core] Use isPureVirtual

    Matching the change in:
    - llvm/llvm-project#78463
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f656008 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    6ff579f View commit details
    Browse the repository at this point in the history
  23. [core] Include missing headers

    - Include `StringExtras.h`
    This is now needed due to:
    llvm/llvm-project@3ff3af3
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    97244c0 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    57468c8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    bcac194 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    6dbb74f View commit details
    Browse the repository at this point in the history
  27. [cling] Adapt tok::eof -> tok::annot_repl_input_end

    In LLVM 18 with incremental extensions enabled, the Preprocessor will
    never report tok::eof, but tok::annot_repl_input_end instead.
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a3c84ee View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    fb5505c View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    37cb102 View commit details
    Browse the repository at this point in the history
  30. [cling] Do not report an error if the fileType is a tapi_file

    Prevents failures such as:
    
    ```
    Processing roottest/root/meta/runnamespace.C...
    Error in cling::MetaProcessor: cannot read from binary input:
    'runnamespace.C'
    ```
    This is needed for macros that start with `{` after the rebase
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fc2002f View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    c28b205 View commit details
    Browse the repository at this point in the history
  32. [cling] Fix C++20 builds

    C++20 builds were failing due to the commit:
    llvm-project/commit/574ee1c02ef73b66c5957cf93888234b0471695f
    
    with an error `imported non C++20 importable modules`
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8962e22 View commit details
    Browse the repository at this point in the history
  33. [cling] Move generators to ProcessSymbols JITDylib

    This makes them run after the <Platform> library: It provides the
    __cxa_atexit function, which must not be found in the process.
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3eb76a4 View commit details
    Browse the repository at this point in the history
  34. [cling] Replace symbols in platform Dylib

    LLVM now defines multiple Dylibs, and __cxa_atexit is provided in
    the <Platform> library.
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6ab0c92 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    9d2327b View commit details
    Browse the repository at this point in the history
  36. [cling] Clear JITDylibs manually to avoid assertion failure

    We started seeing an assertion failure in ~FinalizedAlloc when we
    moved the generators to ProcessSymbols JITDylib:
    [cling] Move generators to ProcessSymbols JITDylib
    
    This ikely changed the destruction order that caused the assertion to
    trigger.
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7a91b7e View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    70a1cdb View commit details
    Browse the repository at this point in the history
  38. [cling] Fix option parsing, again

    This fixes the Cling test Driver/E.C.
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4950e9f View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    bdd8080 View commit details
    Browse the repository at this point in the history
  40. [runtime_cxxmodules] Fix macOS 13 modulemap for LLVM 18

    This applies the upstream changes in commit
    llvm/llvm-project@9992b38
    to a copy of the modulemap from MacOSX14.2.sdk.
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6055bab View commit details
    Browse the repository at this point in the history
  41. [cling] Store enum values as data members to fix cppyy enum tests

    This fixes the failing python enum tests like:
    - `roottest-python-cpp-cpp`
    - `roottest-python-cmdLineUtils-ROOT_8197`
    
    Also remove `R__BYTESWAP` which should not be needed anymore.
    
    The leak was fixed with:
    llvm/llvm-project#78311
    
    This caused our tests to fail as they relied on the
    previous behavior.
    devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cdfabcb View commit details
    Browse the repository at this point in the history
  42. [cling] Fix weak hidden symbols on AArch64

    Upstream LLVM now unconditionally uses indirect / PC relative
    personality encodings since commit
    llvm/llvm-project@ca65969
    
    This leads to references of DW.ref.__gxx_personality_v0 that cannot
    be resolved with RuntimeDyld, that we are still using for the moment.
    As a fix, auto-claim symbols as we are doing for PPC, see upstream commit:
    llvm/llvm-project@72ea1a7
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b9005fd View commit details
    Browse the repository at this point in the history
  43. [core] Fix ASan build with LLVM 18

    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bc96e54 View commit details
    Browse the repository at this point in the history
  44. [cling] Enable JITLink by default for AArch64 on Linux

    There are still failures with RuntimeDyld on AArch64 which seem to
    be solved with JITLink, so make the switch now.
    hahnjo authored and devajithvs committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a52d34d View commit details
    Browse the repository at this point in the history