-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new tuple structure along with new methods of computing Tau Trigger SFs #5
Open
rdewanje
wants to merge
79
commits into
cms-tau-pog:master
Choose a base branch
from
HEP-KBFI:new-tuple
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- crab_submit.py: calling crab in separate process in order to avoid collisions of CMSSW caches introduced in the new crab versions. - tag and prob tuples: - removed debug printonts; - storing HLT objects with of all types; - storing MiniAOD index of HLT objects.
…ls into new-tuple-update
- made branchname for weights configurable in createTrunOn.py script (either "weight" or "final_weight", i.e. either without or with the new background estimation feature)
… scripts in Konstantin's workflow)
- set fit-range to 20-120 GeV by default - merge highest pT bin so that rightmost point always extends all the way up to 120 GeV
- added some debug print-out
- added some debug print-out
…ins with negative bin-content
- disabled debug output
…ing negative. In this case, the bins of the rebinned histogram are merged from right to left until the bin-content in the rightmost bin is >= 0
…of tau pT - extend binning up to 200 GeV to better fit trigger efficiency plateau region (even if high pT region is dominated by background)
… by the chi^2 condition)
…ndEfficiency function
… bins need to be merged from right to left in order to avoid negative bins
…threshold for all rebinned "passed" and "failed" histograms also, as suggested by Konstantin, to handle case of too small uncertainties on efficiency, which constrains fit too much
…ncy for data - disabled debug output
- added horizontal lines at 1 to guide the eye (for top and bottom part of fit plot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploaded all my final changes and files to the repository along with a README.md and a python script that runs the full workflow.