Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepTau v2p5 integration #161

Conversation

ofivite
Copy link
Member

@ofivite ofivite commented May 9, 2022

Description:

This PR adapts DeepTauId producer to a new v2p5 training. The changes aren't significant since the architecture and data preprocessing hasn't changed much structurally. They include:

Backward-compatibility checks:

[v2p1] updated CMSSW code fully reproduces predictions for default (previous) CMSSW
[v2p5] prediction & grid differences for the same model between updated CMSSW and python standalone inference are negligible -- O(1e-5)

P.S. Thanks a lot @kandrosov @shedprog @lguzzi for us working together on this integration!

@mbluj
Copy link

mbluj commented May 9, 2022

@ofivite thank you for the PR. I am starting to revise it. To allow me to run updated code with the 2p5 training, you should also prepare a PR with new training graphs with the trianing to https://github.com/cms-tau-pog/RecoTauTag-TrainingFiles/tree/DeepTau2017v2p5

@mbluj
Copy link

mbluj commented May 9, 2022

@ofivite After a quick review I do not see any significant issues. I plan implement a few small and cosmetics changes myself together with adding the new version of deepTau to the miniAOD workflow. I will keep you informed in case some issues or questions are raised during central review.

@mbluj mbluj merged commit b72e737 into cms-tau-pog:CMSSW_12_4_X_tau-pog_deepTau-v2p5 May 9, 2022
@ofivite
Copy link
Member Author

ofivite commented May 9, 2022

Perfect, thank you @mbluj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants