This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 503
Add Sqlancer Test Type and Installation Requirements #1500
Open
dniu16
wants to merge
4
commits into
cmu-db:master
Choose a base branch
from
dniu16:sqlancer_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apavlo
suggested changes
Mar 12, 2021
from ..util.constants import DIR_TMP | ||
|
||
# git settings for sqlancer. | ||
SQLANCER_GIT_URL = "https://github.com/dniu16/sqlancer.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to https://github.com/cmu-db/sqlancer
Major Decrease in PerformanceSTOP: this PR has a major negative performance impact
|
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
- Coverage 81.79% 81.78% -0.02%
==========================================
Files 706 706
Lines 50425 50425
==========================================
- Hits 41246 41239 -7
- Misses 9179 9186 +7
Continue to review full report at Codecov.
|
lmwnshn
removed
the
ready-for-ci
Indicate that this build should be run through CI.
label
Mar 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the sqlancer test type following the instruction here: https://github.com/cmu-db/noisepage/tree/master/script/testing. The test can be run using the command "PYTHONPATH=.. python3 -m script.testing.sqlancer" under the noisepage directory.
In addition, maven is installed in installation/package.sh since it is needed to build sqlancer.