Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nowcast #1909

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Remove nowcast #1909

merged 2 commits into from
Nov 10, 2023

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Nov 10, 2023 •
edited
Loading

  • Remove directory nowcast and everything in it.
  • Remove nowcast from python-ci and create-release.

See cmu-delphi/delphi-epidata#1323 for more details.

@minhkhul minhkhul changed the title remove nowcast remove nowcast from CI Nov 10, 2023
@minhkhul minhkhul changed the title remove nowcast from CI Remove nowcast Nov 10, 2023
@minhkhul minhkhul changed the title Remove nowcast Remove nowcast from CI only Nov 10, 2023
nmdefries
nmdefries approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Looks like we don't have any associated params files in ansible. Should we add a tag to mark the final version of this package?

@minhkhul minhkhul changed the title Remove nowcast from CI only Remove nowcast Nov 10, 2023
@minhkhul minhkhul merged commit d09f871 into main Nov 10, 2023
14 checks passed
@dshemetov
Copy link
Contributor

Made a tag here.

@melange396 melange396 deleted the delete-nowcast branch November 10, 2023 22:37
@dshemetov dshemetov mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmdefries nmdefries nmdefries approved these changes

@dshemetov dshemetov Awaiting requested review from dshemetov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minhkhul @dshemetov @nmdefries