Make SirCal send alert about nchs lag only after 19 days #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Please update the local/test version of the params, too. With that change, this looks good.
The change for chng will be in a different PR?
melange396
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Yeah, like @nmdefries said, be sure to change the other file to match. This file is named "template" -- does that mean we have to do anything specialy when deploying to get it to apply?
|
@nmdefries The chng lag is fixed now by moving sircal to running 30 minutes later than usual to give time for other processes to finish up. So no need for sircal changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://cmu-delphi.atlassian.net/browse/OKRF23-81