NWSS: post-staging fixes/updates #1924
Conversation
|
its not directly related to the scope of this venture, but its close enough in form to include here as well: itd be good if we changed |
|
done; Minh had already covered like half, this was just the remaining |
|
awesome, thanks! |
| ].values | ||
| nyc_list = raw_df.loc[ | ||
| (raw_df["state"] == "New York City") & (raw_df[metric].isnull()), | ||
| "timestamp", |
There was a problem hiding this comment.
Should trailing comma at end of list be consistent (i.e. either always end in a comma like line 65 or end with no comma like line 61)?
| "timestamp", | |
| "timestamp" |
There was a problem hiding this comment.
oh whoops. My styler was unhappy with this file, and I accidentally included it's changes.
|
@dsweber2 How much of the changes in nwss_wastewater in this PR (that went stale because of negative values from my understanding) is still relevant? These ansible and nchs_mortality changes should be going out at some point after a small vault update. But I'm not sure how much of the nwss_wastewater part still holds now. |
|
it's mostly name changes and docs which still apply. I probably should've marked this as non-draft and based my other PR on it |
The first commit is some changes that George recommended after the original PR was merged. This will also be a branch for any changes that need to be made to handle problems found during staging.