-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use delphi_utils.logger instead of copied file #1488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the unrelated whitespace changes, this looks fab
* remove duplicate logger.py in this repo
Quality Gate passedIssues Measures |
I rebased to get recent client changes and separated the whitespace changes in another commit and ignored that commit in blame. |
whoops, the whitespace changes are still showing in blame: https://github.com/cmu-delphi/delphi-epidata/blame/dev/src/acquisition/covidcast/database.py#L125 i didnt realize it before i merged, but i think your force push changed the commit hashes :( |
Ignore the right blame commit this time. See #1488 (comment).
Addresses the comment here. Partial work from #1469.
Summary:
Prerequisites:
dev
branchdev