rvdss interface and new fn layout so current/historical data can be easily fetched #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
changed the title
nmdefries
commented
Oct 16, 2024
| old_detection_data.to_csv('season_2023_2024/' + RESP_COUNTS_OUTPUT_FILE,index=True) | ||
| old_positive_data.to_csv('season_2023_2024/' + POSITIVE_TESTS_OUTPUT_FILE,index=True) | ||
| for i, base_url in enumerate(included_urls): | ||
| dict_list[i]["weekly"] = fetch_dashboard_data(url, 2023) |
There was a problem hiding this comment.
issue: Need to make sure key is one of the three standard keys ("county", "positive", etc)
nmdefries
commented
Oct 16, 2024
src/acquisition/rvdss/run.py
Outdated
| import os | ||
|
|
||
| from delphi.epidata.acquisition.rvdss.utils import get_weekly_data, get_revised_data, get_dashboard_update_date | ||
| from delphi.epidata.acquisition.rvdss.constants import DASHBOARD_BASE_URL, RESP_DETECTIONS_OUTPUT_FILE, POSITIVE_TESTS_OUTPUT_FILE, COUNTS_OUTPUT_FILE |
There was a problem hiding this comment.
issue: check imports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implements interface for
rvdssindicator. Change fn structure. Makes historical data pulling use up-to-date fn args. Marks additional work with "TODO: ". This won't work entirely as-is. At minimum, fn imports need to be updated for the newrun.pyscript.Some files have been renamed.
Looks like that's causing a conflict with the historical fns file.FixedPrerequisites:
devbranchdev