Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate roxygen markdown mode in DESCRIPTION #1

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Activate roxygen markdown mode in DESCRIPTION #1

merged 4 commits into from
Sep 3, 2024

Conversation

brookslogan
Copy link
Collaborator

We already have some markdown syntax in the roxygen comments, so activate markdown mode for this package.

@nmdefries
Copy link
Collaborator

nmdefries commented May 31, 2024 •
edited
Loading

Removed link formatting in f67235a to get tests to pass. Links didn't include URL, but roxygen doesn't seem to automatically create package links, only topic and package::function. #2 substantially changes data docs anyway, so we can change this.

@nmdefries nmdefries self-requested a review September 3, 2024 22:11
nmdefries
nmdefries approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nmdefries nmdefries merged commit 0632a77 into main Sep 3, 2024
2 checks passed
@nmdefries nmdefries deleted the lcb/activate-roxygen-markdown branch September 3, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmdefries nmdefries nmdefries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brookslogan @nmdefries