-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check dots empty #281
Merged
Merged
Check dots empty #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajmcdon
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. The dots arguments are a bit complicated. See for example: https://adv-r.hadley.nz/s3.html#s3-arguments
My understanding is that
- The S3 generics in this package need
...
because methods may have different arguments. So generics should nevercheck_dots_*
. - methods "can" have
check_dots_*
. However, I've tried to make my versions of functions in{recipes}
have similar constructions. So, e.g.,epi_recipe
methods don't check becauserecipe
methods don't check. I'm not sure I could articulate a reason, but my assumption is "they know better". add_model()
should check because the{workflows}
analogues (e.g.,add_preprocessor()
does.- The
slather()
methods are more complicated. These aren't particularly user facing, so it may not matter. Thebake()
methods in{recipes}
generally don't check, so I haven't (as in point 2) for example,bake.*()/prep.*()
I've tried to comment on each individually.
dajmcdon
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276. the different commits identify confidence in actually using
check_dots_used
. The slather cases were the most ambiguous to me