Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load_all patch, and Roxygen update #282

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix: load_all patch, and Roxygen update #282

merged 2 commits into from
Jan 18, 2024

Conversation

dsweber2
Copy link
Contributor

This makes it so that quantile_reg and smooth_quantile_reg only get defined as new models if they aren't already in the current model namespace. Debugging these still requires restarting R; for everything else, there's devtools::load_all() (which works now).

In the process of writing this, roxygen ran into issues where the new version didn't recognize `%@%` and needed just a bare %@%.

@dsweber2 dsweber2 requested a review from dajmcdon as a code owner January 18, 2024 00:58
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also delete .Rprofile. Once you make these minor changes, feel free to merge.

R/make_quantile_reg.R Outdated Show resolved Hide resolved
R/make_quantile_reg.R Outdated Show resolved Hide resolved
@dsweber2 dsweber2 merged commit ee11b1e into main Jan 18, 2024
2 checks passed
@dshemetov dshemetov deleted the loadallFix branch January 18, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants