Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Djm/plotting #295

Merged
merged 31 commits into from
Apr 7, 2024
Merged

Djm/plotting #295

merged 31 commits into from
Apr 7, 2024

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Mar 6, 2024 •
edited
Loading

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Makes sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

dajmcdon and others added 25 commits November 5, 2023 09:20
@dajmcdon
implement epi_df method
13b9fd9
@dajmcdon
document / export
dd17058
@dajmcdon
missing rlang hook
d6524ee
@dajmcdon
fix a bug that might have allowed unordered quantile extrapolation, s…
04742ed 
…implify options
@dajmcdon
add autoplot method
8c62229
@dajmcdon
ignore vignette caches
fb74311
@dajmcdon
use the autoplot method in epiprocess
08947ed
@dajmcdon
merge dev
103a601 
Merge branch 'dev' into djm/plotting

# Conflicts:
#	.Rprofile
#	NAMESPACE
@dajmcdon
fix: naming issue, missing dots arg
a2af588
@dajmcdon
add documentation, fix ahead/lag behaviour
593208b
@dajmcdon
drafted
dde25f1
@dajmcdon
import ggplot2
6ee75c4
@dajmcdon
remove test for old internal function
af47f09
@dajmcdon
typo in subfunction name
6809dda
@dajmcdon
prefix head()/tail()
59a5485
@dajmcdon
rm: from suggests to imports
042073a
@dajmcdon
ignore the dev md
db5acde
@dajmcdon
merge dev, quantile handling
6eb8863 
Merge branch 'dev' into djm/plotting

# Conflicts:
#	R/dist_quantiles.R
@dajmcdon
complete dev quantile merge
95ce4d3
@dajmcdon
remove test for deleted function
046e7de
@dajmcdon
complete merge, checks pass
a06286e
@dajmcdon
add plotting to pkgdown, clean up references
86b8708
@dajmcdon
revert changes
410da60
@dajmcdon
bump version, add to news
29673be
@dajmcdon
Merge branch 'dev' into djm/plotting
e66e75f
@dajmcdon dajmcdon marked this pull request as ready for review April 2, 2024 05:33
@dajmcdon dajmcdon requested review from dsweber2 and dshemetov April 2, 2024 05:34
dshemetov
dshemetov reviewed Apr 2, 2024
View reviewed changes
DESCRIPTION Show resolved Hide resolved
dshemetov
dshemetov approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few docs change and added a few snapshot tests. Example plots looked good locally.

@dajmcdon dajmcdon merged commit fc67900 into dev Apr 7, 2024
3 checks passed
@dajmcdon dajmcdon deleted the djm/plotting branch April 7, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

@dsweber2 dsweber2 Awaiting requested review from dsweber2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dajmcdon @dshemetov