arx_* without latency adjustment #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is purely before any work on latency adjusting, and is just about geting the tests to run without warnings or skipped tests. Getting this involved: 1. renaming some lingering examples of p to probs and `q` to `quantile_levels` (and some `quantile_level`s to the plural) 2. Adding snapshots so the tests for printing in population_scaling work as intended (should probably be converted to cli_informs at some point) 3. removing the nearly empty `test-propagate_samples` which seems like something intended that was never finished. Probably want to add an issue if we actually want it done. 4. added a bunch of `edf`'s in unhappy `prep` steps
- drop multiline pipes - better docs - check exclusive parameters aren't used simultaneously - inherit typo - additional placeholders for future tests
initial layer adjustments
dsweber2
force-pushed
the
adjustAhead
branch
from
986b657 to
aefc06c
Compare
dsweber2
force-pushed
the
adjustAhead
branch
4 times, most recently
from
36341a5 to
09fd4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change explanations for reviewer
If we don't want latency adjustment in
arx_forecasterandarx_classifier, this removes themMagic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch