Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

356 pivot quantiles bug #357

Merged
merged 4 commits into from
Jul 8, 2024
Merged

356 pivot quantiles bug #357

merged 4 commits into from
Jul 8, 2024

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Jul 8, 2024 •
edited
Loading

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

(merge #355 first)

@dajmcdon dajmcdon requested a review from dsweber2 July 8, 2024 21:48
dsweber2
dsweber2 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems legit. Weird that pivot_wider lets you ignore uniqueness for columns but not rows

@dsweber2
Copy link
Contributor

dsweber2 commented Jul 8, 2024

oh, given that we just incremented the patch in #355 earlier today, I would say we can lump this in as a patch.

@dajmcdon dajmcdon merged commit 21034df into dev Jul 8, 2024
2 checks passed
@dshemetov dshemetov deleted the 356-pivot-quantiles-bug branch July 8, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsweber2 dsweber2 dsweber2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pivot_quantiles_wider() gives strange behaviour if there's only 1 quantile
2 participants
@dajmcdon @dsweber2